Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return nonzero exit code for GitHub exceptions #261

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Apr 12, 2022

Resolves #255

Changes the exception handling so that it returns a non-zero exit code. Throws if exception is unexpected.

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner April 12, 2022 00:41
@ryfu-msft ryfu-msft requested review from yao-msft and removed request for a team April 12, 2022 00:41
@ghost ghost added the Issue-Bug label Apr 12, 2022
@ryfu-msft ryfu-msft merged commit 81263e5 into microsoft:main Apr 12, 2022
@ryfu-msft ryfu-msft deleted the rateLimitError branch April 12, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub rate limiting error doesn't cause wingetcreate to fail
2 participants